Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Creation of new doc on security #19778

Closed
wants to merge 3 commits into from
Closed

feat:Creation of new doc on security #19778

wants to merge 3 commits into from

Conversation

kushthedude
Copy link

Description

  • Adding documentation about security

Related Issues

Fixes #13305

@kushthedude kushthedude requested review from a team as code owners November 25, 2019 16:57
@kushthedude
Copy link
Author

@marcysutton @sidharthachatterjee @KyleAMathews Please review and suggest changes to the following.

@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Nov 26, 2019
@LekoArts
Copy link
Contributor

@kushthedude Please stop mentioning/pinging people after 5 hours of opening your PR. We're considering this rude behavior (please read our Code of Conduct: https://www.gatsbyjs.org/contributing/code-of-conduct/).

We're trying to look at all PRs in a timely manner but your PR is not the only one that needs to be looked at. Furthermore, you're probably in another timezone so please also think about that. Thanks!

@kushthedude
Copy link
Author

kushthedude commented Nov 26, 2019 via email

kushthedude and others added 2 commits November 26, 2019 23:34
Co-Authored-By: LB <laurie@gatsbyjs.com>
Co-Authored-By: LB <laurie@gatsbyjs.com>
@kushthedude
Copy link
Author

@laurieontech commited the changes

@laurieontech
Copy link
Contributor

Hey @kushthedude, thanks for the PR! Lots of good info here. With such a large document it's going to take us a bit to complete the review, so hang tight.

@kushthedude
Copy link
Author

kushthedude commented Nov 26, 2019 via email

@laurieontech laurieontech added this to In progress in Documentation Roadmap via automation Nov 26, 2019
@laurieontech laurieontech moved this from In progress to PRs for Review in Documentation Roadmap Nov 26, 2019
@moonmeister
Copy link
Contributor

moonmeister commented Nov 28, 2019

This is just copied from the the blog post I wrote on the Gatsby blog and is fairly blatant plagiarism (your comment seems to take credit for the content).

That blog post is why issue #13305 exists (as noted in the issue description). No one at the time of my writing that post expected my post to become the security document and there is no benefit to wholesale copying content from one URL to another.

If the Gatsby team feels it'd be beneficial to use the content of my post as the basis of the security document that's fine, but I'd still expect at least some basic re-organization and modification to make it read like documentation and not a blog post.

@kushthedude
Copy link
Author

kushthedude commented Nov 28, 2019 via email

@moonmeister
Copy link
Contributor

The only two commits I see from your original commit are you committing the suggestions made by @laurieontech. You could start by showing your work. It'll take some finagling, but including, in a commit, all the changes you made from the original post would be acceptable to show your work for now.

That said, based on my cherry picking various sentences and reviewing the general outline, I did not see any changes (aka. plagiarism).

What actually needs to happen is you need to start from the beginning, writing your own content or at least organizing and collating content . If you want to quote me directly do so, if you want to pull ideas from my work or others that is fine. But just like I did in my post, you need to use footnotes or inline references to give credit to the original authors.

@marcysutton gave a sentence or two description of what she expected in the original issue #13305. I suggest re-reading that and starting from there.

Ultimately, you need to be knowledgeable enough on security to be able to put together this security content, it is okay you are not, but plagiarism of my content or anyone else's content is not acceptable.

@kushthedude
Copy link
Author

kushthedude commented Nov 28, 2019 via email

@LekoArts LekoArts added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Nov 28, 2019
@m-allanson
Copy link
Contributor

Hey @kushthedude - please don't plagiarise the work of others. That is unacceptable behaviour here.

The content of this PR is almost identical to @moonmeister's blog post. As your PR is a) duplicate content and b) does not credit the original author I am closing it.

We'd love to see a PR that creates this doc, but it must be original content and credit any references where needed.

@m-allanson m-allanson closed this Nov 28, 2019
Documentation Roadmap automation moved this from PRs for Review to Done Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Docs: Create new doc on security
5 participants