-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Creation of new doc on security #19778
Conversation
@marcysutton @sidharthachatterjee @KyleAMathews Please review and suggest changes to the following. |
@kushthedude Please stop mentioning/pinging people after 5 hours of opening your PR. We're considering this rude behavior (please read our Code of Conduct: https://www.gatsbyjs.org/contributing/code-of-conduct/). We're trying to look at all PRs in a timely manner but your PR is not the only one that needs to be looked at. Furthermore, you're probably in another timezone so please also think about that. Thanks! |
Also I have already read the COC for Gatsby before contributing to it,
hence I dont think it is anywhere wrong to ask for review by pinging.
…On Tue, 26 Nov, 2019, 17:00 Lennart, ***@***.***> wrote:
@kushthedude <https://github.com/kushthedude> Please stop
mentioning/pinging people after 5 hours of opening your PR. We're
considering this rude behavior (please read our Code of Conduct:
https://www.gatsbyjs.org/contributing/code-of-conduct/).
We're trying to look at all PRs in a timely manner but your PR is not the
only one that needs to be looked at. Furthermore, you're probably in
another timezone so please also think about that. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19778?email_source=notifications&email_token=AKQMTLWDRFBEFWNE43Z5CZ3QVUCG3A5CNFSM4JRL44S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFWD3Q#issuecomment-558588398>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLUX7LO6EL2OJZ6NWCDQVUCG3ANCNFSM4JRL44SQ>
.
|
Co-Authored-By: LB <laurie@gatsbyjs.com>
Co-Authored-By: LB <laurie@gatsbyjs.com>
@laurieontech commited the changes |
Hey @kushthedude, thanks for the PR! Lots of good info here. With such a large document it's going to take us a bit to complete the review, so hang tight. |
Sure hanging in there for the review👍
…On Tue, 26 Nov, 2019, 23:38 LB, ***@***.***> wrote:
Hey @kushthedude <https://github.com/kushthedude>, thanks for the PR!
Lots of good info here. With such a large document it's going to take us a
bit to complete the review, so hang tight.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19778?email_source=notifications&email_token=AKQMTLVAIIWWRYNLMDBBFFTQVVQ2LA5CNFSM4JRL44S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFG6BTI#issuecomment-558751949>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLQ4XGPBBRMBMFHZCWTQVVQ2LANCNFSM4JRL44SQ>
.
|
This is just copied from the the blog post I wrote on the Gatsby blog and is fairly blatant plagiarism (your comment seems to take credit for the content). That blog post is why issue #13305 exists (as noted in the issue description). No one at the time of my writing that post expected my post to become the security document and there is no benefit to wholesale copying content from one URL to another. If the Gatsby team feels it'd be beneficial to use the content of my post as the basis of the security document that's fine, but I'd still expect at least some basic re-organization and modification to make it read like documentation and not a blog post. |
I did make some changes to remove the Gist of blog post from the following.
It would be great of there some suggestion you can give
…On Thu, 28 Nov, 2019, 08:19 Alex Moon, ***@***.***> wrote:
This is just copied from the the blog post
<https://www.gatsbyjs.org/blog/2019-04-06-security-for-modern-web-frameworks/>
I wrote on the Gatsby blog and is fairly blatant plagiarism. That blog post
is why issue #13305 <#13305>
exists (because we realized there was a lack of security content
surrounding Gatsby). No one at the time of my writing that post expected my
post to become that security document and there is no benefit to wholesale
copying content from one URL to another.
If the Gatsby team feels it'd be beneficial to use the content of my post
as the basis of the security document that's fine, but I'd still expect at
least some basic re-organization and modification to make it read like
documentation and not a blog post.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19778?email_source=notifications&email_token=AKQMTLT26CVC74KM7QZK5CLQV4WVFA5CNFSM4JRL44S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLIW6A#issuecomment-559319928>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLUFWTSLA6F6F7AZTZLQV4WVFANCNFSM4JRL44SQ>
.
|
The only two commits I see from your original commit are you committing the suggestions made by @laurieontech. You could start by showing your work. It'll take some finagling, but including, in a commit, all the changes you made from the original post would be acceptable to show your work for now. That said, based on my cherry picking various sentences and reviewing the general outline, I did not see any changes (aka. plagiarism). What actually needs to happen is you need to start from the beginning, writing your own content or at least organizing and collating content . If you want to quote me directly do so, if you want to pull ideas from my work or others that is fine. But just like I did in my post, you need to use footnotes or inline references to give credit to the original authors. @marcysutton gave a sentence or two description of what she expected in the original issue #13305. I suggest re-reading that and starting from there. Ultimately, you need to be knowledgeable enough on security to be able to put together this security content, it is okay you are not, but plagiarism of my content or anyone else's content is not acceptable. |
👍 Dont worry, I will remove all of your content. Thanks for the concern.
…On Thu, 28 Nov, 2019, 09:26 Alex Moon, ***@***.***> wrote:
The only two commits I see from your original commit are you committing
the suggestions made by @laurieontech <https://github.com/laurieontech>.
You could start by showing your work. It'll take some finagling, but
including, in a commit, all the changes you made from the original post
would be acceptable to show your work for now.
That said, based on my cherry picking various sentences and reviewing the
general outline, I did not see any changes (aka. plagiarism).
What actually needs to happen is you need to start from the beginning,
writing your own content or at least organizing and collating content . If
you want to quote me directly do so, if you want to pull ideas from my work
or others that is fine. But just like I did in my post, you need to use
footnotes or inline references to *give credit to the original authors*.
@marcysutton <https://github.com/marcysutton> gave a sentence or two
description of what she expected in the original issue #13305
<#13305>. I suggest re-reading
that and starting from there.
Ultimately, you need to be knowledgeable enough on security to be able to
put together this security content, it is okay you are not, but plagiarism
of my content or anyone else's content is not acceptable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19778?email_source=notifications&email_token=AKQMTLQY2SUQWQWKMP6DKCLQV46P3A5CNFSM4JRL44S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLLT2A#issuecomment-559331816>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLSSJ54MPZVWM5KR7XLQV46P3ANCNFSM4JRL44SQ>
.
|
Hey @kushthedude - please don't plagiarise the work of others. That is unacceptable behaviour here. The content of this PR is almost identical to @moonmeister's blog post. As your PR is a) duplicate content and b) does not credit the original author I am closing it. We'd love to see a PR that creates this doc, but it must be original content and credit any references where needed. |
Description
Related Issues
Fixes #13305