fix(gatsby): do not cause stack overflow over circular refs #19802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
changed the title
|
Thanks @cameron-martin for the inspiration! |
pieh
reviewed
Nov 26, 2019
| }) => { | ||
| const updateValueDescriptor = ( | ||
| { nodeId, key, value, operation = `add` /*: add | del*/, descriptor = {} }, | ||
| path = [] |
There was a problem hiding this comment.
other places use Set for keeping track if already visited things, was there special reason to use array here?
There was a problem hiding this comment.
I benchmarked it, this seemed more efficient (although it could be variation). Perhaps because this is an explicit push/pop stack, where the other is arbitrary push.
pieh
reviewed
Nov 26, 2019
This allows nodes to have a circular dependency without causing stack overflow exceptions when traversing the graph. Fixes #11364 (hopefully). Will have to confirm this after publishing an update. Causes somewhere between 0 and 1% perf regression for our 25k page benchmark site.
|
Rebased |
sidharthachatterjee
approved these changes
Nov 26, 2019
sidharthachatterjee
added
the
bot: merge on green
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…#19802) * fix(gatsby): do not cause stack overflow over circular refs This allows nodes to have a circular dependency without causing stack overflow exceptions when traversing the graph. Fixes gatsbyjs#11364 (hopefully). Will have to confirm this after publishing an update. Causes somewhere between 0 and 1% perf regression for our 25k page benchmark site. * Use actual `if` for conditionals * Only add data to the path when actually an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows nodes to have a circular dependency without causing stack overflow exceptions when traversing the graph.
Fixes #11364 (hopefully). Will have to confirm this after publishing an update.
Causes somewhere between 0 and 1% perf regression for our 25k page benchmark site. But it's within variance of benchmarking, not even sure if there's a noticable regression at all. See this table:
The first two columns are on master (at the time of writing), the third and fourth column are after this change. (The
(govbook)lines are printed from within the benchmark site). Shrug.