Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-transformer-sharp): remove fragment copying from plugins #19933

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

tmaximini
Copy link
Contributor

@tmaximini tmaximini commented Dec 3, 2019

Description

Since #15284, fragments no longer need to be copied over to the .cache directory because gatsby looks through node_modules

This PR removes that copying mechanism from gatsby-transformer-sharp and gatsby-source-contentful and updates its peer dependencies to "gatsby": "^2.12.1"

@tmaximini tmaximini requested a review from a team as a code owner December 3, 2019 13:08
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Thomas! It was great pairing with you 💚

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 3, 2019
@sidharthachatterjee sidharthachatterjee removed the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 3, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 3, 2019
@gatsbybot gatsbybot merged commit 3d6bfee into gatsbyjs:master Dec 3, 2019
@gatsbot
Copy link

gatsbot bot commented Dec 3, 2019

Holy buckets, @tmaximini — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants