Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Cards for Blog index #2017

Merged
merged 5 commits into from
Sep 5, 2017
Merged

Conversation

fk
Copy link
Contributor

@fk fk commented Sep 4, 2017

… and >="Tablet", below that breakpoint it's basically still the same layout for now. Minus the "Blog" headline, which I haven't thought about at all up to writing this TBH… (wouldn't be wrong to keep it around I guess, and properly hide it with screenreaders in mind).

image

Explicitly sets the excerpt for (two) blog articles along the way – just so much nicer already without that ellipsis (maybe we should go for extracting the first paragraph somehow). Anyways, those two excerpts probably still need some editing … maybe you could take a look @KyleAMathews and @DSchau? 🙏

Also refines the "light purple" and sidebar colors – all are now a little warmer, moved towards the homepage masthead backgrounds left triangle color, and brings the sidebars webkit scrollbar thumb color in line with the brand.

image

Refine light purple and sidebar colors.
Explicitly set excerpt for (two) blog articles along the way.
@gatsbybot
Copy link
Collaborator

gatsbybot commented Sep 4, 2017

Deploy preview ready!

Built with commit 8c20947

https://deploy-preview-2017--gatsbygram.netlify.com

@fk fk changed the title [www] First shot at cards for >="Tablet" [www] Cards for Blog index Sep 4, 2017
@KyleAMathews
Copy link
Contributor

Looking great! The wording on the two excerpts looks good to me.

BTW, there's an error when building www right now.

@fk
Copy link
Contributor Author

fk commented Sep 4, 2017

BTW, there's an error when building www right now.

Grrrr … lemme have a look.
Btw., I can't get format-www to work, should it? packages work just fine.

@fk
Copy link
Contributor Author

fk commented Sep 4, 2017

Fixed … 🙄 😅 If you're okay with the other two excerpts being truncated this is good to go from my side (not saying that all is done of course ;-)).

Split view for contributor pages next … or sidebar?!

@KyleAMathews
Copy link
Contributor

@KyleAMathews
Copy link
Contributor

It might be nice to have the whole card be clickable

@KyleAMathews
Copy link
Contributor

Also something that could be fun is to add back the "Blog" header but add some old fashioned curly whatevers around it to look like an old-fashioned nameplate/masthead

@fk
Copy link
Contributor Author

fk commented Sep 4, 2017

Wow, you actually read my mind twice, both were on my (secret ;)) list! You hit the nail on the head regarding the masthead – when I wrote about "keeping the <h1> around", I immediately tought of s/th like "The Gatsby Times" :)

Will fix the link in a few. To keep the link to the author page working, we can either handle clicks via JS, add another <a> for the article link and stretch it to cover the whole card, then bring the author link up via z-index … or do weird things, namely TLDR wrap the nested (author) link in an <object>tag … ;)

Florian Kissling and others added 2 commits September 5, 2017 00:58
Currently done by overlaying the newly added "Read more" link over the entire card and pushing the link to the author's page up via `z-index`.
Has the drawback of the text not being user-selectable anymore.

Changed BlogPostPreviewItem root HTML element from `<div>` to `<article>` along the way.
@KyleAMathews KyleAMathews merged commit b7e9d06 into gatsbyjs:master Sep 5, 2017
@KyleAMathews
Copy link
Contributor

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants