Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Updated with Windows Configuration #20361

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

JoseSoteloCohen
Copy link
Contributor

Added SET GATSBY_GRAPHQL_IDE=playground&gatsby develop as the configuration needed to make it work in Windows.

Description

Added SET GATSBY_GRAPHQL_IDE=playground&gatsby develop as the configuration needed to make it work in Windows.

After reading the docs I was unable to find a solution to why it wasn't working on my local environment until I finally found the solution on a Spectrum post, so I think that this information should be in the docs to make it easy for newcomers like myself.

Documentation

Gatsby Graphql Playground docs

Added SET GATSBY_GRAPHQL_IDE=playground&gatsby develop as the configuration needed to make it work in Windows.
@JoseSoteloCohen JoseSoteloCohen requested a review from a team as a code owner December 31, 2019 11:20
@laurieontech laurieontech added this to In progress in Documentation Roadmap via automation Jan 3, 2020
@laurieontech laurieontech moved this from In progress to PRs for Review in Documentation Roadmap Jan 3, 2020
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jan 8, 2020
@LekoArts LekoArts changed the title Updated with Windows Configuration chore(docs): Updated with Windows Configuration Jan 8, 2020
@vladar
Copy link
Contributor

vladar commented Jan 13, 2020

We mention cross-env in one of our articles. I'd recommend using it instead of SET variable

@JoseSoteloCohen
Copy link
Contributor Author

We mention cross-env in one of our articles. I'd recommend using it instead of SET variable

Updated it! plus added a way to install cross-env

@laurieontech
Copy link
Contributor

@JoseSoteloCohen would love to get this merged! Could you address Vlad's most recent comment and we can get this in?

@laurieontech laurieontech added the status: awaiting author response Additional information has been requested from the author label Feb 12, 2020
Tried it out and worked too

Co-Authored-By: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
@JoseSoteloCohen
Copy link
Contributor Author

@laurieontech Vladar is right, it wasn't needed so I accepted the suggestion :)

@laurieontech
Copy link
Contributor

Awesome! Let's get this in.

@laurieontech laurieontech merged commit 0d4de52 into gatsbyjs:master Feb 13, 2020
Documentation Roadmap automation moved this from PRs for Review to Done Feb 13, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 13, 2020

Holy buckets, @JoseSoteloCohen — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants