Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-source-contentful): Fix stack overflow cycles #20674

Merged
merged 3 commits into from
Jan 21, 2020
Merged

chore(gatsby-source-contentful): Fix stack overflow cycles #20674

merged 3 commits into from
Jan 21, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Jan 17, 2020 •
edited
Loading

  • This change will cause the contentful data to be changed inline, rather than mapped. I don't expect this to be breaking in any way, but it is a change.
  • This fixes some cycle issues in contentful.
  • It also fixes an issue where the data isn't properly walked.

This fixes the repro reported in #11364

@pvdz pvdz requested a review from a team as a code owner January 17, 2020 16:44
This was referenced Jan 17, 2020
Closed
Closed
@ma-pe
Copy link

ma-pe commented Jan 20, 2020

I am also experiencing issues with the plugin exceeding the stack size. I'd love to check if your pull request solves these issues.

Yet I am struggling to link the pr with my package.json due to the gatsby repo being a monorepo. Do you know of an easy way to try out this pr?

@pvdz
Copy link
Contributor Author

pvdz commented Jan 20, 2020

You could try to patch node_modules manually.

I don't expect this to take too long to get merged.

wardpeet
wardpeet reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't know much about this code but I don't see any problems with it. I added some nits and asked for a few comments ^^

packages/gatsby-source-contentful/src/normalize.js Show resolved Hide resolved
packages/gatsby-source-contentful/src/normalize.js Outdated Show resolved Hide resolved
packages/gatsby-source-contentful/src/normalize.js Show resolved Hide resolved
@pvdz pvdz requested a review from wardpeet January 21, 2020 13:02
blainekasten
blainekasten approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels sane. The only thing I am left wanting for is you describe a spec where if the id is a number, then you prefix it with c. However I'm not seeing a snapshot for this case. Would love to see one. But the code looks solid!

@pvdz
Copy link
Contributor Author

pvdz commented Jan 21, 2020

#resolved :)

@pvdz pvdz merged commit fe83100 into master Jan 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the contentful-cycles branch January 21, 2020 19:22
@bsgreenb bsgreenb mentioned this pull request Apr 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pvdz @ma-pe @wardpeet @blainekasten