-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-preload-fonts): Add option to run in CI #21037
Conversation
I'm had a problem with writing up the docs, because I feel like there's no need to inform about the way it's checked but just inform that the option is there. Also I wonder if in this case it would be useful to note that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding docs info! Left a comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learning approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@masives PR looks great, just need to get the automated tests to pass (may be worth rebasing on latest |
Co-Authored-By: Aaron Ross <superhawk610@gmail.com>
14a7af6
@superhawk610 Seems like after merging still some packages fail. Also when I run locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a comment would be good here. Perhaps a reporter action as well.
packages/gatsby-plugin-preload-fonts/src/prepare/fetch-routes.js
Outdated
Show resolved
Hide resolved
@pvdz I believe this was solved now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @masives! This looks awesome 👏!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💜
Holy buckets, @masives — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Added non-interactive option of using plugin using isCI utility.
Documentation
I've added small section with information about this feature.
Related Issues
Addresses #20185