Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-preload-fonts): Add option to run in CI #21037

Merged
merged 12 commits into from
Mar 2, 2020

Conversation

masives
Copy link
Contributor

@masives masives commented Jan 30, 2020

Description

Added non-interactive option of using plugin using isCI utility.

Documentation

I've added small section with information about this feature.

Related Issues

Addresses #20185

@masives masives requested review from a team as code owners January 30, 2020 09:17
@masives masives changed the title [gatsby-plugin-preload-fonts]Font preload ci [gatsby-plugin-preload-fonts]Add option to run in CI Jan 30, 2020
@masives
Copy link
Contributor Author

masives commented Jan 30, 2020

I'm had a problem with writing up the docs, because I feel like there's no need to inform about the way it's checked but just inform that the option is there. Also I wonder if in this case it would be useful to note that the font-preload-cache.json should be added to .gitignore file. @superhawk610

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding docs info! Left a comment below.

packages/gatsby-plugin-preload-fonts/README.md Outdated Show resolved Hide resolved
@pieh pieh changed the title [gatsby-plugin-preload-fonts]Add option to run in CI feat(gatsby-plugin-preload-fonts): Add option to run in CI Jan 31, 2020
laurieontech
laurieontech previously approved these changes Feb 4, 2020
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learning approved!

superhawk610
superhawk610 previously approved these changes Feb 8, 2020
Copy link
Contributor

@superhawk610 superhawk610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

packages/gatsby-plugin-preload-fonts/README.md Outdated Show resolved Hide resolved
@superhawk610 superhawk610 added effort: low status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Feb 8, 2020
@superhawk610
Copy link
Contributor

@masives PR looks great, just need to get the automated tests to pass (may be worth rebasing on latest master since it seems that failures are coming from other packages).

@masives
Copy link
Contributor Author

masives commented Feb 12, 2020

@superhawk610 Seems like after merging still some packages fail. Also when I run locally
yarn jest packages/gatsby-plugin-preload-fonts --watch I receive errors on missing packages. Can you suggest how should I run these?

image

pvdz
pvdz previously requested changes Feb 12, 2020
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment would be good here. Perhaps a reporter action as well.

@masives
Copy link
Contributor Author

masives commented Feb 27, 2020

@pvdz I believe this was solved now

@masives masives requested a review from pvdz February 27, 2020 20:36
@wardpeet wardpeet self-assigned this Feb 29, 2020
wardpeet
wardpeet previously approved these changes Mar 2, 2020
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @masives! This looks awesome 👏!

@wardpeet wardpeet added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Mar 2, 2020
wardpeet
wardpeet previously approved these changes Mar 2, 2020
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

@wardpeet wardpeet merged commit 131f1e8 into gatsbyjs:master Mar 2, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 2, 2020

Holy buckets, @masives — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants