Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Update broserslist dep #21992

Merged
merged 3 commits into from
Mar 10, 2020
Merged

chore(gatsby): Update broserslist dep #21992

merged 3 commits into from
Mar 10, 2020

Conversation

grigiriy
Copy link
Contributor

@grigiriy grigiriy commented Mar 5, 2020

There is an error :
"Module build failed (from ./node_modules/postcss-loader/src/index.js):BrowserslistError: Browser queries must be an array or string. Got object."
and if I go deeper:
"Unknown browser query dead "

all other dependencies got 4+ version of browserslist package, which resolve this issue.

Got an issue when tried to migrate product based on "create react app" with "node-sass" package installed, to gatsby.

There is an issue 
"Unknown browser query `dead` " with old browserslist.
and
Module build failed (from ./node_modules/postcss-loader/src/index.js):BrowserslistError: Browser queries must be an array or string. Got object.

Got an issue when tried to migrate product based on "create react app" with "node-sass" package installed, to gatsby.
@grigiriy grigiriy requested a review from a team as a code owner March 5, 2020 18:28
@pieh
Copy link
Contributor

pieh commented Mar 6, 2020

What are breaking changes between browserlist 3 and 4?

@pieh pieh self-assigned this Mar 10, 2020
@pieh pieh changed the title Update broserslist dep chore(gatsby): Update broserslist dep Mar 10, 2020
@pieh
Copy link
Contributor

pieh commented Mar 10, 2020

What are breaking changes between browserlist 3 and 4?

Answering my own question - https://github.com/browserslist/browserslist/blob/master/CHANGELOG.md#400-erinaceus-amurensis :

- Add node X and maintained node versions queries (by Pavel Vostrikov).
- Remove Node.js 4 support.
- Show warning if caniuse-lite is old (by Anton Tuzhik).
- Add comma support in config file.

So we should be good.

I'm still not clear for me how this fixes the error you described. But using latest browserslist seems good enough reason to bump.

@pieh pieh merged commit dc4e21e into gatsbyjs:master Mar 10, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 10, 2020

Holy buckets, @grigiriy — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants