Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Convert babel-parse-to-ast to TypeScript #22480

Conversation

john015
Copy link
Contributor

@john015 john015 commented Mar 22, 2020

Description

Convert src/utils/babel-parse-to-ast.js to TypeScript.

I could not use ParserOptions Interface exported by @babel/parser to declare the return value of the getBabelParserOptions function.

Because the ParserOptions interface and PARSER_OPTIONS declared in the babel-parse-to-ast.js file are incompatible.

So instead of ParserOptions interface, I temporarily declared the return value of the getBabelParserOptions function as object type.

Related Issues

Related to #21995

@john015 john015 requested a review from a team as a code owner March 22, 2020 13:17
@john015 john015 force-pushed the chore/convert-babel-parse-to-ast-to-typescript branch from adc412d to 4e099d4 Compare March 22, 2020 14:49
@john015 john015 force-pushed the chore/convert-babel-parse-to-ast-to-typescript branch from 4e099d4 to 08ac352 Compare March 22, 2020 16:01
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten merged commit 21f3dfb into gatsbyjs:master Mar 23, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 23, 2020

Holy buckets, @john015 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pvdz
Copy link
Contributor

pvdz commented Mar 24, 2020

Published in gatsby@2.20.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants