New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge latest changes when asserting changes #22539
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
force-pushed
the
chore/assert-changes-update
branch
from
March 24, 2020 09:55
b0133c7
to
4bc98f7
Compare
blainekasten
previously approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve because this all looks reasonable and good. A couple nits that I think could be simplified, but it's ultimately nit. :)
wardpeet
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Mar 24, 2020
blainekasten
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We see a lot of failing PRs happening lately because of our starters_validate step. It diffs the branch with the latest master and sees if any changes have happened on starters/ or .circle folders. Most of our publishes change the starters folder which means all newly created PRs who didn't start from master will fail on this test.
I altered the script to git merge the latest master before we do the check to see if any real changes were made. This should reduce the number of failures.