Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge latest changes when asserting changes #22539

Merged
merged 10 commits into from Mar 25, 2020

Conversation

wardpeet
Copy link
Contributor

Description

We see a lot of failing PRs happening lately because of our starters_validate step. It diffs the branch with the latest master and sees if any changes have happened on starters/ or .circle folders. Most of our publishes change the starters folder which means all newly created PRs who didn't start from master will fail on this test.

image

#!/bin/bash -eo pipefail
./scripts/assert-changed-files.sh "starters/*|.circleci/*"
1 file(s) matching 'starters/*|.circleci/*'; continuing.
CircleCI received exit code 0

I altered the script to git merge the latest master before we do the check to see if any real changes were made. This should reduce the number of failures.

@wardpeet wardpeet requested review from a team as code owners March 24, 2020 09:35
@wardpeet wardpeet force-pushed the chore/assert-changes-update branch from b0133c7 to 4bc98f7 Compare March 24, 2020 09:55
blainekasten
blainekasten previously approved these changes Mar 24, 2020
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve because this all looks reasonable and good. A couple nits that I think could be simplified, but it's ultimately nit. :)

@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 24, 2020
@gatsbybot gatsbybot merged commit d30832b into master Mar 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/assert-changes-update branch March 25, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants