Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-contentful): use request url for base64 image cache key #22745

Merged
merged 2 commits into from
Apr 2, 2020
Merged

fix(gatsby-source-contentful): use request url for base64 image cache key #22745

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5191fc0
fix(gatsby-source-contentful): use request url for base64 image cache…
disintegrator Apr 2, 2020
71c72b0
Apply suggestions from code review
wardpeet Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gatsby-source-contentful/src/extend-node-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const getBase64Image = imageProps => {

// Note: sha1 is unsafe for crypto but okay for this particular case
const shasum = crypto.createHash(`sha1`)
shasum.update(`requestUrl`)
shasum.update(`${requestUrl}`)
wardpeet marked this conversation as resolved.
Show resolved Hide resolved
const urlSha = shasum.digest(`hex`)

// TODO: Find the best place for this step. This is definitely not it.
Expand Down