Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my progress on updating to node 13 and typescript support, since type… #22817

Closed

Conversation

JustFly1984
Copy link

My digs on node13 typescript and issues with types.

…script issues with ConfigStore and Module import issues
@pieh
Copy link
Contributor

pieh commented Apr 6, 2020

I just want to mention that bumping min Node version to 13 is not going to happen very soon - only about ~13% of gatsby sessions make use of Node 13.

@pvdz
Copy link
Contributor

pvdz commented Apr 16, 2020

@JustFly1984 it looks like this is a massive PR which attempts to bump many packages and the node minver. As @pieh pointed out, we're not going to bump the minver for nodejs until 10 is no longer an LTS, and then we'll bump it to 12.

I'm going to close this PR because I don't think it'll be meaningful for us to keep up. If you can slice this PR up in smaller chunks that don't require bumping the nodejs minver, nor the gatsby major, then please submit them.

Thank you

@pvdz pvdz closed this Apr 16, 2020
@JustFly1984
Copy link
Author

The point of this PR is to show you that single dependency on node13 Module interface through @types/node@13.x in gatsby-cli would lead to whole list of packages to depend on node13. Please do something about it, cos current @types/node@12.x does not support Module, and would not, cos Module will not be backported from 13 to 12. And also please use advice of @awwit to customise each package’s tsconfig.json file to include only used @types/*, so there will be no types conflicts and collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants