Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Convert prefer-default to TypeScript #22958

Closed
wants to merge 2 commits into from
Closed

chore(gatsby): Convert prefer-default to TypeScript #22958

wants to merge 2 commits into from

Conversation

grikomsn
Copy link

@grikomsn grikomsn commented Apr 9, 2020

Description

This PR converts packages\gatsby\src\bootstrap\prefer-default.js to TypeScript

Related Issues

Related to #21995

@grikomsn
Copy link
Author

grikomsn commented Apr 9, 2020

Since this is my first time contributing to Gatsby's codebase and most of the tests are failing, is there any references on how and where should I fix it?

@blainekasten
Copy link
Contributor

@grikomsn So sorry friend. Thank you for your hard work. It seems someone else put up a PR for the same module and I merged theirs before I saw yours 😢

I am so sorry and I hope you are still interested in contributing to our TS conversion. This was incredibly valuable work and I feel terrible for losing your time on this.

I think if you're interested, a really easy module to get your hands dirty would be to do reducers/flattened-plugins. Let me know if you are interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants