Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes theme recipe #24219

Merged
merged 2 commits into from May 26, 2020
Merged

Add notes theme recipe #24219

merged 2 commits into from May 26, 2020

Conversation

laurieontech
Copy link
Contributor

New recipe for adding the notes theme to your site

@laurieontech laurieontech requested a review from a team as a code owner May 19, 2020 12:45
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 19, 2020
@laurieontech laurieontech added topic: recipes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 19, 2020
---
Now let's add a note!

<File path="content/notes/learning.md" content="https://gist.githubusercontent.com/laurieontech/cf90cbee0bc69b106f2fa5109d055372/raw/58a012c02b6e9fffe3e93bc2a57bd5f01ef281b8/learning.md"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be nodes/learning.md as that's the basePath? Or does theme-notes assume stuff is under content?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to content/notes as the file directory. basePath is for navigation to the notes listing page.

@KyleAMathews KyleAMathews added this to In progress in Gatsby Recipes via automation May 26, 2020
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Gatsby Recipes automation moved this from In progress to Reviewer approved May 26, 2020
@KyleAMathews KyleAMathews merged commit c83a762 into master May 26, 2020
Gatsby Recipes automation moved this from Reviewer approved to Done May 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the recipe-notes-theme branch May 26, 2020 15:11
johno pushed a commit to johno/gatsby that referenced this pull request May 28, 2020
* Add notes theme recipe

* Update gatsby-theme-notes.mdx

Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants