Prompt to choose different port if :8000 is already in use #25016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
approved these changes
Jun 16, 2020
ascorbic
added
topic: cli
mxstbr
added
the
bot: merge on green
|
It seems at least one test is broken now. From the e2e_tests_development_runtime output:
|
ascorbic
removed
the
bot: merge on green
|
People are still running into this (including me!), and looks like it got stalled. Can it be revisited? looks like there's a merge conflict. |
|
This was fixed in #25863 by the amazing @polarathene! Sorry for letting this set for so long, completely my bad, this drowned in my brain 😬 Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #24854 by moving the "detect if port is in use and prompt to choose different one" logic to the parent process.
As the develop process now runs on a random unused port anyway, this code path is irrelevant for it. However, the proxy now listens at
:8000(or the user-selected port) so we need it to detect and prompt instead.