Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): Add theme ui as dependency to solve npm bug #25122

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

laurieontech
Copy link
Contributor

For some reason theme-ui is not being hoisted in the blog theme when using npm. This bug does not exist when using yarn.

As a workaround, adding theme-ui to the starter dependencies.

Closes #25093

@laurieontech laurieontech requested a review from a team as a code owner June 19, 2020 14:03
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 19, 2020
@laurieontech laurieontech added topic: themes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 19, 2020
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💣

@wardpeet wardpeet changed the title Add theme ui as dependency to solve npm bug chore(starters): Add theme ui as dependency to solve npm bug Jun 19, 2020
@laurieontech laurieontech merged commit 7fd4806 into master Jun 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the npm-resolution-bug branch June 19, 2020 14:24
axe312ger pushed a commit that referenced this pull request Jun 23, 2020
Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home>
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Co-authored-by: Laurie Barth <laurie@LauriesrkLaptop.fios-router.home>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants