chore: Update @hapi/joi

[herecydev]

Fixes #25764

[hueniverse]

Please switch the dependency to joi (no longer under @hapi/joi). If I can help in any way, please let me know. Thanks!

[hueniverse]

Are you back on the hapi version because of typescript?

[herecydev]

Are you back on the hapi version because of typescript?

Yep, was going to shoot a message across but you beat me to it! If there's an easy way to solve this let me know! Otherwise I feel like taking a phased approach works best for me:

1. Get stuff upgraded so it's not deprecated anymore
2. Change to the joi package (as I understand it's the same thing but it's future will be in the sideway repo?)

[hueniverse]

I will get the type definitions copied over to the original namespace so it will resolve this. Meanwhile your plan sounds good.

[herecydev]

Eran, I'm struggling to understand the translation of joi-to-graphql.js. There's a lot of _meta and _children that I'm unsure of. I got somewhere by using .describe() but I'm new to joi so probably need some advice here.

Hope that's okay?

[hueniverse]

I'm surprised how deep this code goes into joi internals...

You are on the right track with describe(). It should includes everything you need since that information is enough to rebuild the schema. Take a look at https://github.com/sideway/joi/blob/master/test/manifest.js#L20 for an example.

I am happy to try and help but I can't figure out how to run the tests for this code.

[herecydev]

So a little further on... It looks like the file enumerates the keys of the current schema and switches based on whether it's an object, array or lazy. The fields returned looked like:

[
      {
        key: 'name',
        schema: {
          isJoi: true,
          _type: 'string',
          _settings: null,
          _valids: [InternalSet],
          _invalids: [InternalSet],
          _tests: [],
          _refs: [],
          _flags: {},
          _description: null,
          _unit: null,
          _notes: [],
          _tags: [],
          _examples: [],
          _meta: [],
          _inner: {},
          _currentJoi: [Object]
        }
      },
      {
        key: 'description',
        schema: {
          isJoi: true,
          _currentJoi: [Object],
          _type: 'string',
          _settings: null,
          _baseType: undefined,
          _valids: [InternalSet],
          _invalids: [InternalSet],
          _tests: [],
          _refs: [],
          _flags: [Object],
          _description: null,
          _unit: null,
          _notes: [],
          _tags: [],
          _examples: [],
          _meta: [],
          _inner: {}
        }
      },
...
]

I got something similar using object.extract() which gave me the matching fields schema. I just don't really know how to procede with schema._tests or schema._flags.presence. I can't find any docs on those fields

For reference I've never used Joi so this is a bit of a learning curve for me. @ascorbic

[hueniverse]

@herecydev You should only use describe(). Everything else is joi internals and will break randomly as I change things.

[herecydev]

@ascorbic @mxstbr Are you able to provide some assistance with this file? There's too much internal behavior going on but it's really difficult to know the solution without some deeper knowledge in this area

[mxstbr]

We copied-and-edited that code from https://github.com/xogroup/joi2gql, so we're not familiar with it either unfortunately 😬

[herecydev]

😬 that's not ideal. I've raised a ticket upstream.

[herecydev]

@mxstbr not sure how to move this forward. https://github.com/xogroup/joi2gql looks very unloved.

[hueniverse]

Note that joi v17.2.0 is published with TS support under joi.

[LekoArts]

I think this PR got quite stale and diverged from the current master. We still want to do it, but a fresh start should be better than dealing with all the merge conflicts!

We removed gatsby-recipes so the difficult parts should be gone