Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix integration test #26971

Merged
merged 3 commits into from
Sep 21, 2020
Merged

tests: fix integration test #26971

merged 3 commits into from
Sep 21, 2020

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Sep 21, 2020 •
edited

Description

Add a few missing deps and also changed the way we invoke

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 21, 2020
@wardpeet wardpeet added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 21, 2020
@wardpeet wardpeet marked this pull request as ready for review September 21, 2020 12:28
pvdz
pvdz approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Let's hope it works.

I assume master package.json was dirty? :(

@LekoArts LekoArts merged commit ece4a6e into gatsbyjs:master Sep 21, 2020
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@ViCo0TeCH
tests: fix integration test (gatsbyjs#26971)
150f1ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wardpeet @pvdz @LekoArts