Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Remove --save from install prompts #26985

Merged
merged 61 commits into from
Sep 23, 2020
Merged

fix(docs): Remove --save from install prompts #26985

merged 61 commits into from
Sep 23, 2020

Conversation

lacrosse91
Copy link
Contributor

@lacrosse91 lacrosse91 commented Sep 22, 2020 •
edited

Description

--save is no longer necessary for modern versions of npm, so I fixed pages of docs/docs folder.

Documentation

Related Issues

#22444

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 22, 2020
@lacrosse91 lacrosse91 closed this Sep 22, 2020
@lacrosse91 lacrosse91 reopened this Sep 22, 2020
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 22, 2020
@LekoArts
Copy link
Contributor

I'd be great to change all occurrences of --save in one PR. Would you be up for making the changes?

My IDE finds alone in the docs/docs folder 79 matches:

image

You can ignore the docs/blog folder.

@LekoArts LekoArts changed the title fix(docs): improve Adding Page Metadata fix(docs): Remove --save from install prompts Sep 22, 2020
@lacrosse91
Copy link
Contributor Author

@LekoArts
Thanks for review!
I will change occurrences of --save except for docs/blog folder.

@lacrosse91
Copy link
Contributor Author

lacrosse91 commented Sep 22, 2020 •
edited

@LekoArts
I removed --save from npm install in docs folder except for docs/blog folder .
Please review the changes.

LekoArts
LekoArts approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you very much for those changes! 🎉

@LekoArts LekoArts merged commit 699c526 into gatsbyjs:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lacrosse91 @LekoArts