Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): migrate schema-composer and types/type-defs to typescript #27241

Closed
wants to merge 5 commits into from
Closed

chore(gatsby): migrate schema-composer and types/type-defs to typescript #27241

wants to merge 5 commits into from

Conversation

ThakurKarthik
Copy link

Description

  1. Migrate packages/gatsby/src/schema/schema-composer.js to schema-composer.ts
  2. Migrate packages/gatsby/src/schema/types/type-defs.js to type-defs.ts

Related Issues

Related to #21995

Hi @LekoArts I have made some file changes for migrating to typescript, please review this.All comments are most welcome as i am new to typescript, I will incorportate the changes in the review.
Thanks !

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 2, 2020
@LekoArts LekoArts mentioned this pull request Oct 5, 2020
Closed
@LekoArts LekoArts added hacktoberfest-accepted and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 5, 2020
@ascorbic
Copy link
Contributor

ascorbic commented Oct 8, 2020

Hi @ThakurKarthik
This is failing typechecks. Can you run yarn typecheck in the root and see the errors that you need to fix? You can also click on one of the failing tests above to see the messages too.

@ascorbic ascorbic added the status: awaiting author response Additional information has been requested from the author label Oct 8, 2020
@ThakurKarthik
Copy link
Author

@ascorbic I will check and update the PR.Thanks !

@ThakurKarthik
Copy link
Author

Hey @ascorbic ! I have fixed the typechecks by running yarn typecheck and also fixed some jest cases failing earlier, but i am not sure about what is failing now,can you see if any thing is missing in my current branch as it is saying some missing/does not exist package in failing tests.
Thanks !

@ThakurKarthik ThakurKarthik mentioned this pull request Oct 24, 2020
Closed
@ThakurKarthik
Copy link
Author

Hey @LekoArts can you tell what's failing these tests ? I am not sure what's causing the issue

@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed topic: TypeScript migration labels May 28, 2021
@imjoshin
Copy link
Contributor

Hey! Thanks so much for opening this pull request!

Sadly this PR got stale and didn't have any activity for some time. We're trying to do better with PR reviews! To get a better overview of all actionable PRs we're going through all open PRs and triage them. Since we won't be able to do everything and adding new features always means added maintenance burden, we have to be more picky about what's beneficial for the average user and the project itself longterm.

We think this is a great PR and would love to see it land in Gatsby. We're closing this PR for now but if you're able to rebase onto the latest master branch and try it out with the latest next versions, we'd be happy to review the PR when its re-opened.

We absolutely want to have you as a contributor and are sorry for any inconveniences we caused with replying too late to this PR.

Thanks for submitting to Gatsby! 💜

@imjoshin imjoshin closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: awaiting author response Additional information has been requested from the author topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ThakurKarthik @ascorbic @imjoshin @LekoArts