feat: add utility to show experiment invitation notices #28120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: cli
delete-merged-branch
bot
deleted the
feat/experiment-invitation-notice
branch
muescha
reviewed
Jan 9, 2021
|
|
||
| if (lastTimeWeShowedNotice) { | ||
| if (Date.now() - lastTimeWeShowedNotice < minimumIntervalBetweenNoticesMs) { | ||
| return undefined |
There was a problem hiding this comment.
if you return a noop function then you can avoid the check where it is called
- if (cancelNotice) {
- cancelNotice()
- }
+ cancelNotice()
This was referenced Jul 22, 2022
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds utility to help showing targeted experiment notices in CLI when some work takes more than predefined time threshold. To avoid potentially frustrating spam in CLI it tracks last time it showed that notice and will show it at most once a day (similar to how feedback survey doesn't show too often for same user).
For example usage see pieh@0316827 which would invite user to check out query on demand experiment if their page queries run for at least 2 minutes