Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(develop): add query on demand behind feature flag #28127

Merged
merged 9 commits into from Nov 17, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Nov 17, 2020

This is final piece for implementation of query on demand feature flag

It relies on #27939 ( so target branch is that until it gets merged )

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 17, 2020
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the branch master November 17, 2020 15:36
@vladar
Copy link
Contributor

vladar commented Nov 17, 2020

I like the branch name 😉

@pieh pieh marked this pull request as ready for review November 17, 2020 16:02
@pieh pieh changed the base branch from vladar/page-data-util to master November 17, 2020 16:02
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One thing that requires attention is a leftover for trackDirtyQuery in the query reducer as it is unconditional.

packages/gatsby/cache-dir/dev-loader.js Show resolved Hide resolved
packages/gatsby/cache-dir/dev-loader.js Show resolved Hide resolved
packages/gatsby/cache-dir/dev-loader.js Show resolved Hide resolved
packages/gatsby/src/redux/types.ts Show resolved Hide resolved
packages/gatsby/src/services/calculate-dirty-queries.ts Outdated Show resolved Hide resolved
packages/gatsby/src/services/calculate-dirty-queries.ts Outdated Show resolved Hide resolved
packages/gatsby/src/redux/reducers/queries.ts Outdated Show resolved Hide resolved
packages/gatsby/src/redux/reducers/queries.ts Show resolved Hide resolved
packages/gatsby/src/utils/websocket-manager.ts Outdated Show resolved Hide resolved
pieh and others added 9 commits November 17, 2020 18:17
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
…lized

user can have satured runtime caches and restart dev server which means they might
miss some invalidation messages and would need to manually refresh browser
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work! Let's ship it 🚢

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 17, 2020
@gatsbybot gatsbybot merged commit 088eef4 into master Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the qod/connect-all-the-dots branch November 17, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants