Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): invite people with long page query running to try out query on demand feature #28181

Merged
merged 1 commit into from
Nov 19, 2020
Merged

feat(gatsby): invite people with long page query running to try out query on demand feature #28181

merged 1 commit into from
Nov 19, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Nov 19, 2020

This will show notice about query on demand opt-in feature when page query running takes longer than 2 minutes - very similar to #28116

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 19, 2020
@pieh pieh added topic: query on demand* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 19, 2020
vladar
vladar approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I assume GATSBY_EXPERIMENTAL_FAST_DEV is also covered as we set GATSBY_EXPERIMENTAL_QUERY_ON_DEMAND manually in this case?

@vladar vladar changed the title feat(gatsby): invite people with long page query running to try out quer y demand feature feat(gatsby): invite people with long page query running to try out query on demand feature Nov 19, 2020
@pieh
Copy link
Contributor Author

pieh commented Nov 19, 2020

Nice! I assume GATSBY_EXPERIMENTAL_FAST_DEV is also covered as we set GATSBY_EXPERIMENTAL_QUERY_ON_DEMAND manually in this case?

Yes - it will set the process.env.GATSBY_EXPERIMENTAL_QUERY_ON_DEMAND which will make the condition for showing notice not met anymore - so we won't try to invite users that are already trying it out :)

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 19, 2020
@gatsbybot gatsbybot merged commit 413888b into master Nov 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the qod/show-invite-notice-if-query-running-takes-long-time branch November 19, 2020 13:47
@pieh pieh added this to To cherry-pick in V2 Release hotfixes via automation Nov 19, 2020
vladar pushed a commit that referenced this pull request Nov 19, 2020
@pieh @vladar
feat(gatsby): invite people with long page query running to try out q…
6c1e852 
…uery on demand feature (#28181)

(cherry picked from commit 413888b)
@vladar vladar mentioned this pull request Nov 19, 2020
Merged
vladar added a commit that referenced this pull request Nov 19, 2020
@vladar @pieh
feat(gatsby): invite people with long page query running to try out q…
4b9cd2e 
…uery on demand feature (#28181) (#28185)

(cherry picked from commit 413888b)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@vladar vladar moved this from To cherry-pick to Backported in V2 Release hotfixes Nov 19, 2020
@kaocher82 kaocher82 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Jul 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
No open projects
V2 Release hotfixes
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pieh @vladar @gatsbybot