chore(e2e-pnp): don't pin berry version #28286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: automation
|
Awesome! I'm working through failing e2e tests on a PR and this one was next. Glad it's not my fault 😂 |
vladar
added
the
bot: merge on green
delete-merged-branch
bot
deleted the
e2e-pnp/dont-pin-version-and-use-latest-available-berry
branch
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our e2e pnp tests pin yarn 2 versions to quite outdated rc version and recently started failing constantly. This is due to some patches that needs to be applied to typescript to work with PnP. I'm very light on details here, check comments I linked below. At the time comments were made patch was already updated, but wasn't released yet (it might have been already released, it might not - TBD, will see how tests run on this PR I guess and we will be able to rerun them periodically if it wasn't released yet).
Removing pinning was suggested by Yarn 2 maintainers (in one of linked comments)
Related Issues
This was PR unrelated to PnP, but comments there are actually relevant
#28218 (comment)
#28218 (comment)
#28218 (comment)