fix(gatsby): fix broken GraphQL resolver tracing

[vladar]

Description

Our resolver tracing is broken ATM. Tracing simply counts sync resolver call. It doesn't await the returned promise and ends the activity immediately. So it kinda tracks sync resolvers but not async.

With this change, we track correctly in both cases.

[pvdz]

Oh yeah we discussed this the other day. The fix is good but the timing will probably be very off since it would encompass anything that happens while the thread is suspended. Anyways, good fix.

[pvdz]

This can be dropped since we test and shortcut return above

[vladar]

Typescript disagrees.

This file has incomplete typings but if I add proper typings to activity and remove this check I get TS error: TS2339: Property 'end' does not exist on type 'void | IActivity'.   Property 'end' does not exist on type 'void'.

[pvdz]

While this won't swallow the error, I think it will suppress nodejs' builtin reporting for uncaught promises (right? because it sees the error is handled at least somewhere)

[vladar]

No, it's a different promise chain than the one returned. So it is not affecting unhandled rejections. Also double-checked with this example in node:

const foo = new Promise(function (resolve, reject) {
  setTimeout(() => {
    reject(new Error("Err"));
  }, 1000);
});

const func = () => {};

foo.then(func, func);

foo.then(() => { console.log(`test`); });

[KyleAMathews]

🚢