fix(gatsby): Always render the body component to ensure needed head & pre/post body components are added #29077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pre/post body components are added For client-only pages, we just want to render an empty body but we do want the other components rendered
gatsbot
bot
added
the
status: triage needed
vladar
added
bot: merge on green
vladar
approved these changes
Jan 18, 2021
This was referenced Jan 19, 2021
Open
This was referenced Jan 1, 2024
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For client-only pages, we just want to render an empty body but we do want the other components rendered.
Fixes problem raised by @martinhj and verified in @nikoladev's reproduction #28138 (reply in thread)