Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-plugin-remove-graphql-queries): make sure imports are posix #29144

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jan 22, 2021

Added slash to babel-plugin-remove-graphql-queries so imports are following esm syntax on every platform.
public\\sq\\d\\<hash.json => public/sq/d/<hash.json

I've updated the tests to actually test this behaviour.

[ch22209]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 22, 2021
@wardpeet wardpeet added status: needs core review Currently awaiting review from Core team member type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 22, 2021
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@wardpeet wardpeet merged commit 3a5a855 into gatsbyjs:master Jan 22, 2021
@wardpeet wardpeet deleted the fix/static-query-import branch January 22, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: needs core review Currently awaiting review from Core team member type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants