Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gatsby-source-contentful): Add info to readme on use with new image plugin #29297

Merged
merged 3 commits into from Feb 2, 2021
Merged

docs(gatsby-source-contentful): Add info to readme on use with new image plugin #29297

merged 3 commits into from Feb 2, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 2, 2021

This adds some brief documentation on how to use the experimental support for gatsby-plugin-image with Contentful

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 2, 2021
@ascorbic ascorbic added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 2, 2021
@ascorbic ascorbic added this to To cherry-pick in Release candidate via automation Feb 2, 2021
laurieontech
laurieontech reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the steps based instructions ensure people don't miss things. Would like to drop in a link to the docs unless you think there are too many discrepancies in the available API?

Other than that, looks good!

packages/gatsby-source-contentful/README.md Outdated Show resolved Hide resolved
packages/gatsby-source-contentful/README.md Outdated Show resolved Hide resolved
packages/gatsby-source-contentful/README.md Outdated Show resolved Hide resolved
ascorbic and others added 2 commits February 2, 2021 15:08
@ascorbic
Apply suggestions from code review
b1fb3e7 
Co-authored-by: LB <laurie@gatsbyjs.com>
@ascorbic
Add link to plugin
92f99f2
laurieontech
laurieontech previously approved these changes Feb 2, 2021
View reviewed changes
@ascorbic ascorbic merged commit c9d4f07 into master Feb 2, 2021
@ascorbic ascorbic deleted the docs/contentful-image-readme branch February 2, 2021 15:17
@ascorbic ascorbic mentioned this pull request Feb 2, 2021
Merged
ascorbic added a commit that referenced this pull request Feb 2, 2021
@ascorbic
docs(gatsby-source-contentful): Add info to readme on use with new im…
2ddd607 
…age plugin (#29297)

* docs(gatsby-source-contentful): Add info to readme on use with new image plugin

* Apply suggestions from code review

Co-authored-by: LB <laurie@gatsbyjs.com>

* Add link to plugin

Co-authored-by: LB <laurie@gatsbyjs.com>
(cherry picked from commit c9d4f07)
@ascorbic ascorbic moved this from To cherry-pick to Backport PR opened in Release candidate Feb 2, 2021
ascorbic added a commit that referenced this pull request Feb 2, 2021
@ascorbic
docs(gatsby-source-contentful): Add info to readme on use with new im…
929281c 
…age plugin (#29297) (#29301)

* docs(gatsby-source-contentful): Add info to readme on use with new image plugin

* Apply suggestions from code review

Co-authored-by: LB <laurie@gatsbyjs.com>

* Add link to plugin

Co-authored-by: LB <laurie@gatsbyjs.com>
(cherry picked from commit c9d4f07)
@ascorbic ascorbic moved this from Backport PR opened to Backported in Release candidate Feb 2, 2021
@snyk-bot snyk-bot mentioned this pull request Jul 21, 2021
Open
This was referenced Feb 18, 2022
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ascorbic @laurieontech