Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Correct layout proptypes in StaticImage #29298

Merged
merged 1 commit into from Feb 2, 2021
Merged

fix(gatsby-plugin-image): Correct layout proptypes in StaticImage #29298

merged 1 commit into from Feb 2, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 2, 2021

Fix the proptype comparison, as it was trying to compare a lower-case value with a camel-case option. I think it's fine to insist on correct casing here.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 2, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 2, 2021
@ascorbic ascorbic added this to To cherry-pick in Release candidate via automation Feb 2, 2021
wardpeet
wardpeet approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 2, 2021
@ascorbic ascorbic merged commit 0b6f2e3 into master Feb 2, 2021
@ascorbic ascorbic deleted the fix/staticimage-proptypes branch February 2, 2021 13:23
ascorbic added a commit that referenced this pull request Feb 2, 2021
@ascorbic
fix(gatsby-plugin-image): Correct layout proptypes in StaticImage (#2…
a9c4a43 
…9298)

(cherry picked from commit 0b6f2e3)
@ascorbic ascorbic mentioned this pull request Feb 2, 2021
Merged
@ascorbic ascorbic moved this from To cherry-pick to Backport PR opened in Release candidate Feb 2, 2021
ascorbic added a commit that referenced this pull request Feb 2, 2021
@ascorbic
fix(gatsby-plugin-image): Correct layout proptypes in StaticImage (#2…
1dec045 
…9298) (#29299)

(cherry picked from commit 0b6f2e3)
@ascorbic ascorbic moved this from Backport PR opened to Backported in Release candidate Feb 2, 2021
@snyk-bot snyk-bot mentioned this pull request Jul 21, 2021
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ascorbic @wardpeet