Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-source-contentful): improve Contentful image handling #29398

Merged
merged 4 commits into from
Feb 11, 2021
Merged

feat(gatsby-source-contentful): improve Contentful image handling #29398

merged 4 commits into from
Feb 11, 2021

Conversation

axe312ger
Copy link
Collaborator

  • ensures we don't request to large images from Contentful's Image API
  • skip non-image assets as Contentful as we do for old image resolvers

@axe312ger axe312ger added status: needs core review Currently awaiting review from Core team member topic: source-contentful Related to Gatsby's integration with Contentful labels Feb 8, 2021
@axe312ger axe312ger self-assigned this Feb 8, 2021
@axe312ger axe312ger added this to In progress in Contentful source plugin improvements via automation Feb 8, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 8, 2021
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 9, 2021
@wardpeet wardpeet changed the title improve Contentful & gatsby-plugin-image feat(gatsby-source-contentful): improve Contentful image handling Feb 10, 2021
@axe312ger axe312ger added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: needs core review Currently awaiting review from Core team member labels Feb 11, 2021
@ascorbic ascorbic merged commit c1e95a4 into master Feb 11, 2021
Contentful source plugin improvements automation moved this from In progress to Done Feb 11, 2021
@ascorbic ascorbic deleted the fix/contentful-gatsby-plugin-image branch February 11, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees

@axe312ger axe312ger

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: source-contentful Related to Gatsby's integration with Contentful
Projects
Contentful source plugin improvements
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axe312ger @ascorbic @LekoArts