Implement step one of refactoring how we handle internal errors #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borrowed a bunch of code from create-react-app. Eventual goal is that we centrally manage all errors so we can print them more tidily in the terminal but also send them to the browser + other places in the future.
|
|
|
Deploy preview ready! Built with commit 0818b9f |
KyleAMathews
commented
Nov 17, 2017
| @@ -70,8 +70,7 @@ async function parseToAst(filePath, fileStr) { | |||
| `There was a problem parsing "${filePath}"; any GraphQL ` + | |||
| `fragments or queries in this file were not processed. \n` + | |||
| `This may indicate a syntax error in the code, or it may be a file type ` + | |||
| `That Gatsby does not know how to parse.`, | |||
| error | |||
There was a problem hiding this comment.
@jquense this wasn't supposed to be there right? The stack trace was just a long bunch of babel parsing nonsense.
KyleAMathews
commented
Nov 17, 2017
| }/___graphql`, | ||
| ], | ||
| }, | ||
| // compilationSuccessInfo: { |
There was a problem hiding this comment.
We're handling this directly now
|
Deploy preview ready! Built with commit 0818b9f |
KyleAMathews
commented
Nov 17, 2017
| // // Only keep the first error. Others are often indicative | ||
| // // of the same problem, but confuse the reader with noise. | ||
| // if (messages.errors.length > 1) { | ||
| // messages.errors.length = 1 |
There was a problem hiding this comment.
we'll restore this replacing FriendlyErrorsWebpackPlugin once the remainder of the error/warning refactoring is done.
KyleAMathews
commented
Nov 17, 2017
| @@ -13,13 +15,15 @@ const handlerP = fn => (...args) => { | |||
| } | |||
|
|
|||
| function buildLocalCommands(cli, isLocalSite) { | |||
| const defaultHost = `localhost` | |||
| const defaultHost = `0.0.0.0` | |||
There was a problem hiding this comment.
Turns out Windows doesn't need us to listen on localhost, just that I guess the browser can't use 0.0.0.0 or something like that.
|
This also adds local network ip (common feature request (thanks CRA)) |
This was referenced Jan 26, 2022
This was referenced Jun 8, 2022
This was referenced Jun 8, 2022
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed a bunch of code from create-react-app.
Eventual goal is that we centrally manage all errors so we can print
them more tidily in the terminal but also send them to the browser +
other places in the future.