Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-image): Apply inline styles and img size #29603

Merged
merged 1 commit into from Feb 19, 2021
Merged

fix(gatsby-plugin-image): Apply inline styles and img size #29603

merged 1 commit into from Feb 19, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 19, 2021 •
edited

Apply inline styles to the wrapper element if the plugin isn't installed. Add width and height props to the img tag. They're not needed as we use CSS, but Lighthouse warns about them anyway

[ch24990]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 19, 2021
laurieontech
laurieontech approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can accept this :)
And ya, the width/height stuff is good to remove the warning.

@ascorbic ascorbic added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 19, 2021
@gatsbybot gatsbybot merged commit 9db36db into master Feb 19, 2021
@gatsbybot gatsbybot deleted the fix/image-wrapper-style branch February 19, 2021 13:35
@ascorbic ascorbic added this to To cherry-pick in V2 Release hotfixes via automation Feb 19, 2021
@gatsbybot gatsbybot mentioned this pull request Feb 22, 2021
Merged
ascorbic added a commit that referenced this pull request Feb 22, 2021
@ascorbic
fix(gatsby-plugin-image): Apply inline styles and img size (#29603)
f316afa 
(cherry picked from commit 9db36db)
ascorbic added a commit that referenced this pull request Feb 22, 2021
@ascorbic
fix(gatsby-plugin-image): Apply inline styles and img size (#29603)
3639b11 
(cherry picked from commit 9db36db)
ascorbic added a commit that referenced this pull request Feb 22, 2021
@ascorbic
fix(gatsby-plugin-image): Apply inline styles and img size (#29603)
c59969a 
(cherry picked from commit 9db36db)
@ascorbic ascorbic moved this from To cherry-pick to Backport PR opened in V2 Release hotfixes Feb 22, 2021
ascorbic added a commit that referenced this pull request Feb 23, 2021
@ascorbic
fix(gatsby-plugin-image): Apply inline styles and img size (#29603) (#…
9183a6b 
…29668)

(cherry picked from commit 9db36db)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@ascorbic
Copy link
Contributor Author

Published in gatsby-plugin-image@0.7.2

@ascorbic ascorbic moved this from Backport PR opened to Backported in V2 Release hotfixes Feb 24, 2021
This was referenced Feb 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
@pieh pieh moved this from Backported to Archived in V2 Release hotfixes Mar 8, 2021
This was referenced May 5, 2021
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 30, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 30, 2022
Open
@0xSebin 0xSebin mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
This was referenced Oct 31, 2022
Open
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
This was referenced Oct 31, 2022
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request Dec 6, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Dec 6, 2023
Open
This was referenced Dec 6, 2023
Open
Open
@monizb monizb mentioned this pull request Dec 6, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 7, 2023
Open
@wizbit wizbit mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 7, 2023
Open
Open
Open
@impactyogi impactyogi mentioned this pull request Dec 7, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 7, 2023
Open
Open
@impactyogi impactyogi mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
V2 Release hotfixes
Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascorbic @laurieontech @gatsbybot