Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): render QoD overlay in its own root element to avoid hydration issues #29692

Merged
merged 5 commits into from Feb 23, 2021
Merged

fix(gatsby): render QoD overlay in its own root element to avoid hydration issues #29692

merged 5 commits into from Feb 23, 2021

Conversation

KyleAMathews
Copy link
Contributor

Clears way to enabling DEV_SSR for everyone.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 22, 2021
wardpeet
wardpeet reviewed Feb 23, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to test but added some small nits. Code looks good

packages/gatsby/cache-dir/app.js Outdated Show resolved Hide resolved
packages/gatsby/cache-dir/app.js Outdated Show resolved Hide resolved
@KyleAMathews KyleAMathews merged commit d3dd3e1 into master Feb 23, 2021
@KyleAMathews KyleAMathews deleted the fix-hydrate branch February 23, 2021 22:26
@KyleAMathews KyleAMathews added topic: ssr and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 23, 2021
@KyleAMathews KyleAMathews added this to To cherry-pick in V2 Release hotfixes via automation Feb 23, 2021
@ascorbic
Copy link
Contributor

This won't apply cleanly to the release branch, as you seem to have changed other things in there. Could you do a new PR against the release branch?

@KyleAMathews
Copy link
Contributor Author

On it 👍

@KyleAMathews KyleAMathews mentioned this pull request Feb 24, 2021
Merged
@ascorbic ascorbic moved this from To cherry-pick to Backport PR opened in V2 Release hotfixes Feb 25, 2021
@ascorbic
Copy link
Contributor

Published in gatsby@2.32.7

@ascorbic ascorbic moved this from Backport PR opened to Backported in V2 Release hotfixes Feb 25, 2021
@pieh pieh moved this from Backported to Archived in V2 Release hotfixes Mar 8, 2021
@LekoArts LekoArts added the topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
No open projects
V2 Release hotfixes
Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KyleAMathews @ascorbic @pieh @wardpeet @LekoArts