fix(gatsby-source-wordpress) HTML link replacement with relative path to include homepage #29841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
|
Oops, looks like I did something silly and 2 merge commits got here :( Is it bad? Update: It is bad so fixed it. I guess I won't use a shallow copy next time :) |
LekoArts
added
topic: source-wordpress
karen-sarkisyan
force-pushed
the
fix/wp-html-links-regex
branch
from
def2644
to
5d71df0
Compare
karen-sarkisyan
force-pushed
the
fix/wp-html-links-regex
branch
from
5d71df0
to
0927b84
Compare
|
Upd: Resolved merge conflict, ran updated tests |
|
Hello Tyler @TylerBarnes ! |
LekoArts
added
the
topic: source-plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a tiny problem in gatsby-source-wordpress plugin when HTML links pointing to WordPress homepage are not being processed into a relative path, effectively pointing to WP host, which may not be desirable. See issue #29417 for details.
I believe this fix should not introduce any bad unintended consequences.
I would highly appreciate any feedback on this PR, it's my first one. 馃コ
Documentation
There's no docs that need to be updated.
Related Issues
Fixes #29417