Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-transformer-sharp): Fix options override #29897

Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix(gatsby-transformer-sharp): Fix options override #29897

merged 1 commit into from
Mar 1, 2021

Conversation

laurieontech
Copy link
Contributor

Formats can be changed with gatsby-plugin-sharp options. This works for StaticImage but currently breaks for GatsbyImage because gatsby-transformer-sharp defaults it for you. Since we're already handling it inside plugin-sharp we can remove the resolver default.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@laurieontech laurieontech added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 1, 2021
@laurieontech laurieontech marked this pull request as draft March 1, 2021 19:55
@laurieontech laurieontech marked this pull request as ready for review March 1, 2021 19:59
@laurieontech laurieontech merged commit 57c131d into master Mar 1, 2021
@laurieontech laurieontech deleted the try-again branch March 1, 2021 20:24
@laurieontech laurieontech added this to To cherry-pick in V2 Release hotfixes via automation Mar 1, 2021
@ascorbic ascorbic added this to To cherry-pick in Release candidate via automation Mar 2, 2021
@gatsbybot gatsbybot mentioned this pull request Mar 2, 2021
Merged
vladar pushed a commit that referenced this pull request Mar 2, 2021
@vladar
will git stop being weird (#29897)
2df99ae 
(cherry picked from commit 57c131d)
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Mar 2, 2021
vladar pushed a commit that referenced this pull request Mar 2, 2021
will git stop being weird (#29897) (#29907)
b2628da 
(cherry picked from commit 57c131d)

Co-authored-by: LB <laurie@gatsbyjs.com>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Mar 2, 2021
@gatsbybot gatsbybot mentioned this pull request Mar 4, 2021
Merged
pieh pushed a commit that referenced this pull request Mar 4, 2021
@pieh
will git stop being weird (#29897)
b02ca7f 
(cherry picked from commit 57c131d)
@pieh pieh moved this from To cherry-pick to Backport PR opened in V2 Release hotfixes Mar 4, 2021
@pieh pieh moved this from Backport PR opened to Backported in V2 Release hotfixes Mar 4, 2021
pieh pushed a commit that referenced this pull request Mar 4, 2021
will git stop being weird (#29897) (#30005)
b576211 
(cherry picked from commit 57c131d)

Co-authored-by: LB <laurie@gatsbyjs.com>
@pieh pieh moved this from Backported to Archived in V2 Release hotfixes Mar 8, 2021
This was referenced Mar 9, 2021
Closed
Closed
Closed
Merged
Closed
Closed
@ajesse11x ajesse11x mentioned this pull request Mar 9, 2021
Open
@kaocher82 kaocher82 mentioned this pull request Mar 9, 2021
Open
@impactyogi impactyogi mentioned this pull request Mar 26, 2024
Open
This was referenced Mar 26, 2024
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
This was referenced Mar 27, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request Mar 27, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Mar 28, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Apr 14, 2024
Open
@wizbit wizbit mentioned this pull request Apr 14, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 14, 2024
Open
@monizb monizb mentioned this pull request Apr 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Apr 15, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Apr 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
@monizb monizb mentioned this pull request Apr 29, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 16, 2024
Open
This was referenced May 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
No open projects
Release candidate
Archived
V2 Release hotfixes
Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laurieontech @ascorbic