fix: use cpuCount for all parallel parts #30548
Conversation
gatsbot
bot
added
the
status: triage needed
wardpeet
added
type: maintenance
|
More cores used on minify? I like! |
| @@ -12,7 +12,7 @@ sharp.simd(true) | |||
| // Handle Sharp's concurrency based on the Gatsby CPU count | |||
| // See: http://sharp.pixelplumbing.com/en/stable/api-utility/#concurrency | |||
| // See: https://www.gatsbyjs.org/docs/multi-core-builds/ | |||
| sharp.concurrency(cpuCoreCount()) | |||
| sharp.concurrency(cpuCoreCount() - 1) | |||
There was a problem hiding this comment.
Does concurrency make sense for the manifest plugin at all? It is for a single icon resizing, right?
There was a problem hiding this comment.
yeah — it wouldn't ever use more than one core
There was a problem hiding this comment.
Problem here is that sharp is a singleton so it will be shared with gatsby-plugin-sharp :'(
There was a problem hiding this comment.
But gatsby-plugin-sharp now has concurrency 1 (after this PR: #28575):
gatsby/packages/gatsby-plugin-sharp/src/process-file.js
Lines 19 to 20 in f628c38
There was a problem hiding this comment.
I wonder what is the actual behavior currently if you have both plugins 🤔
There was a problem hiding this comment.
oh interesting :D I'll set it to one than. Basically last one in gatsby-config wins
|
|
wardpeet
force-pushed
the
fix/cpucount-parallel
branch
from
465404a
to
3847e1e
Compare
Description
Not every part of Gatsby is using
cpuCoreCountand we should always do -1 to make sure the main process is left alone.