Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): rehydration issue in Dev404Page with DEV_SSR #30581

Merged
merged 3 commits into from
May 3, 2021
Merged

fix(gatsby): rehydration issue in Dev404Page with DEV_SSR #30581

merged 3 commits into from
May 3, 2021

Conversation

kimbaudi
Copy link
Contributor

fix rehydration issue in Dev404Page

this PR adds hasMounted state to Dev404Page to fix rehydration issue when DEV_SSR and/or FAST_DEV flags are enabled in gatsby-config.js.

Related Issues

Fixes #30575

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 31, 2021
@LekoArts LekoArts added topic: ssr and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 6, 2021
@LekoArts LekoArts changed the title fix rehydration issue in Dev404Page fix(gatsby): rehydration issue in Dev404Page with DEV_SSR May 3, 2021
LekoArts
LekoArts previously approved these changes May 3, 2021
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 5005588 into gatsbyjs:master May 3, 2021
@kimbaudi kimbaudi deleted the fix-dev4040page-hydration branch May 3, 2021 20:19
@LekoArts LekoArts added the topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Text content did not match' warning in Dev404Page with DEV_SSR or FAST_DEV flag enabled
2 participants