fix(gatsby): Refactor overlay utils #31005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: core
pieh
approved these changes
Apr 23, 2021
| import emitter from "../emitter" | ||
| import { Indicator } from "./indicator" | ||
|
|
||
| // no hooks because we support react versions without hooks support |
Comment on lines
-16
to
-23
| --purple-60: #663399; | ||
| --gatsby: var(--purple-60); | ||
| --purple-40: #b17acc; | ||
| --purple-20: #f1defa; | ||
| --dimmedWhite: rgba(255, 255, 255, 0.8); | ||
| --white: #ffffff; | ||
| --black: #000000; | ||
| --grey-90: #232129; |
There was a problem hiding this comment.
heh, I see quite a few of unused vars we had here 🙈
LekoArts
added
the
topic: DX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR in preparation of moving the
DEV_SSRoverlay to the unified look of our existing Fast Refresh overlay. It moves the sharedcssutility and React Portal to their own files.I also updated the loading indicator to use React hooks and made the CSS variable names more declarative. Also increased the
z-indexone more level.