Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to implement Gatsby's different APIs #3101

Merged
merged 4 commits into from Dec 3, 2017

Conversation

m-allanson
Copy link
Contributor

Add some notes on how to use the various Gatsby API's.

See comment: #2963 (comment)

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 2, 2017

Deploy preview ready!

Built with commit d8587c7

https://deploy-preview-3101--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 2, 2017

Deploy preview ready!

Built with commit d8587c7

https://deploy-preview-3101--gatsbygram.netlify.com

@@ -9,6 +9,10 @@ class BrowserAPIDocs extends React.Component {
return (
<Container>
<h1 css={{ marginTop: 0 }}>Gatsby Browser APIs</h1>
<h2 css={{ marginBottom: rhythm(1 / 2) }}>Usage</h2>
<p>Implement any of these APIs by exporting them from a file named <code>gatsby-browser.js</code> in the root of your project.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-allanson probably want marginBottom: rhythm(1) or something along those lines as opposed to using br tags to control spacing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks 👍

@ghost ghost assigned KyleAMathews Dec 3, 2017
@ghost ghost added the review label Dec 3, 2017
@KyleAMathews
Copy link
Contributor

Thanks! Can't believe I forgot this before 🤦‍♂️

Thanks for this and your other very nice PRs today! Really helpful to get help improving DX from fresh eyes.

@KyleAMathews KyleAMathews merged commit 647bdf0 into gatsbyjs:master Dec 3, 2017
@ghost ghost removed the review label Dec 3, 2017
@m-allanson m-allanson deleted the topics/api-usage branch December 3, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants