fix(gatsby): handle case of changing page path casing on case-insensitive fs #31071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: build
vladar
reviewed
Apr 27, 2021
vladar
pushed a commit
that referenced
this pull request
Apr 27, 2021
…tive fs (#31071) (#31082) * fix(gatsby): handle case of changing page path casing on case-insensitive fs * figure out if platform is case insenstive once and not for every page separately * add tests for casing ... cases (cherry picked from commit 940eddf) Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…tive fs (gatsbyjs#31071) * fix(gatsby): handle case of changing page path casing on case-insensitive fs * figure out if platform is case insenstive once and not for every page separately * add tests for casing ... cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows and MacOs if you change casing of page path it results in page being generated and then deleted.
Consider scenario of creating
/TEST/page and then inonCreatePageadjust page path to lower case which results in/test/page. What currently happen is that/test/is generated and/TEST/is scheduled for deletion. In case insensitive filesystems it means we will delete same files we just created.Related Issues
fixes #31055