Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-wordpress): previewing drafts requires using the preview query #31133

Merged
merged 1 commit into from
Apr 30, 2021
Merged

fix(gatsby-source-wordpress): previewing drafts requires using the preview query #31133

merged 1 commit into from
Apr 30, 2021

Conversation

TylerBarnes
Copy link
Contributor

Following the release of this PR gatsbyjs/wp-gatsby#161 in WPGatsby, previewing drafts now "works" in that it redirects you to the right place at the right time. We also need the change in this PR so that previewing a draft uses the preview query instead of the regular node query.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 30, 2021
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 30, 2021
@TylerBarnes TylerBarnes requested a review from a team April 30, 2021 17:57
@TylerBarnes TylerBarnes added this to To cherry-pick in V3 Release Hotfixes via automation Apr 30, 2021
@TylerBarnes TylerBarnes requested review from veryspry and removed request for a team April 30, 2021 18:43
veryspry
veryspry approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👨‍🎤

@TylerBarnes TylerBarnes merged commit 53f7d7d into master Apr 30, 2021
@TylerBarnes TylerBarnes deleted the fix/wp-drafts-are-previews-too branch April 30, 2021 21:52
vladar pushed a commit that referenced this pull request May 4, 2021
@TylerBarnes @vladar
fix(gatsby-source-wordpress): previewing drafts requires using the pr…
789b30a 
…eview query (#31133)

(cherry picked from commit 53f7d7d)
@gatsbybot gatsbybot mentioned this pull request May 4, 2021
Merged
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes May 4, 2021
vladar pushed a commit that referenced this pull request May 4, 2021
@TylerBarnes
fix(gatsby-source-wordpress): previewing drafts requires using the pr…
22590b4 
…eview query (#31133) (#31243)

(cherry picked from commit 53f7d7d)

Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com>
@vladar vladar moved this from Backport PR opened to Backported in V3 Release Hotfixes May 4, 2021
@vladar
Copy link
Contributor

vladar commented May 4, 2021

Published in gatsby-source-wordpress@5.4.1

@TylerBarnes
Copy link
Contributor Author

Thanks @vladar !

@vladar vladar moved this from Backported to Published in V3 Release Hotfixes May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veryspry veryspry veryspry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
V3 Release Hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TylerBarnes @vladar @veryspry