Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-image] Support image loading with JavaScript disabled #3122

Merged
merged 4 commits into from
Dec 13, 2017
Merged

[gatsby-image] Support image loading with JavaScript disabled #3122

merged 4 commits into from
Dec 13, 2017

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Dec 3, 2017

Resolves #3109.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 3, 2017

Deploy preview ready!

Built with commit 896c187

https://deploy-preview-3122--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 3, 2017

Deploy preview ready!

Built with commit 2fb97a0

https://deploy-preview-3122--using-drupal.netlify.com

@ghost ghost assigned KyleAMathews Dec 12, 2017
@ghost ghost added the review label Dec 12, 2017
@KyleAMathews
Copy link
Contributor

Thanks! Sorry for the long delay on getting this out there — been super busy 😅

@KyleAMathews KyleAMathews merged commit b2a0810 into gatsbyjs:master Dec 13, 2017
@ghost ghost removed the review label Dec 13, 2017
@kripod kripod deleted the gatsby-image/support-disabled-javascript branch December 13, 2017 03:59
@kripod
Copy link
Contributor Author

kripod commented Dec 13, 2017

@KyleAMathews You needn’t be sorry, I can totally understand your situation of being extremely busy. I’m glad that this has finally been merged, I highly appreciate your efforts and attitude towards this project! 😊

@kripod
Copy link
Contributor Author

kripod commented Dec 14, 2017

@KyleAMathews I don't know why, but this seems to break production builds (gatsby build). I get blurry images all over the place along with the following stack trace on my web browser's console:

Uncaught Error: Minified React error #32; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=32&args[]=76 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at n (reactProdInvariant.js:29)
    at u (ReactDOMComponentTree.js:101)
    at l (ReactDOMComponentTree.js:177)
    at v.f (ReactDOMComponent.js:259)
    at e.notifyAll (CallbackQueue.js:74)
    at r.close (ReactReconcileTransaction.js:78)
    at r.closeAll (Transaction.js:207)
    at r.perform (Transaction.js:154)
    at u (ReactMount.js:124)
    at r.perform (Transaction.js:141)

Development builds are fine (gatsby develop).

@KyleAMathews
Copy link
Contributor

Can you try to duplicate this with the using-gatsby-image example site?

@kripod
Copy link
Contributor Author

kripod commented Dec 14, 2017

@KyleAMathews Just visit https://using-gatsby-image.gatsbyjs.org using Chrome v63. It's pretty ironic that gatsby-image now works without JavaScript, but doesn't work with JS enabled.

@KyleAMathews
Copy link
Contributor

Huh... weird this didn't show up in your and my testing.

@KyleAMathews
Copy link
Contributor

This is the issue we're running into facebook/react#1252

@KyleAMathews
Copy link
Contributor

looks like we still have to use dangerouslySetInnerHTML

@KyleAMathews
Copy link
Contributor

I'll work on a PR to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants