fix(gatsby-source-contentful): fix progress bar #31467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
added
topic: source-contentful
|
@vladar I removed in on purpose because the API does not give us a total of items (of the current sync run) The total was always off and confusing. Thats why I removed it. |
|
But now the progress bar shows something line |
|
@vladar we can completely remove the bar. We won't get the required information for a proper progress bar with the current API in use. |
|
Can we just show a regular gatsby style progress indicator? |
|
Any solution that removes the flicker is fine (as for me). |
axe312ger
approved these changes
May 27, 2021
moonmeister
added a commit
to moonmeister/gatsby
that referenced
this pull request
Jun 1, 2021
* master: (23 commits) fix(gatsby-source-wordpress): Prevent "EADDRINUSE: address already in use 127.0.0.1" error (gatsbyjs#31713) feat(gatsby-source-wordpress: architecture.md (gatsbyjs#31537) chore(deps): update dependency @babel/node to ^7.14.2 (gatsbyjs#31690) chore(deps): update babel monorepo (gatsbyjs#31143) fix(gatsby): merge resolveType when merging abstract types (gatsbyjs#31710) chore(release): Publish next fix(gatsby): Correct config for svgo plugins whitelist chore: Add translations and validations to Contentful test (gatsbyjs#31533) chore(docs): Correct nginx spelling (gatsbyjs#31651) chore(docs): Update Jest instructions for v27 (gatsbyjs#31649) Fix typo in adding-search.md (gatsbyjs#31639) Fix typos in improving-build-performance.md (gatsbyjs#31640) feat(gatsby-source-wordpress): Fix false positive error if the URL and the responsePath are the same (gatsbyjs#31612) Fixed syntax error in example (gatsbyjs#31636) fix(contentful): pass reporter to retry function (gatsbyjs#31608) chore: Properly typecheck `gatsby` (gatsbyjs#31519) fix(gatsby-source-contentful): fix progress bar (gatsbyjs#31467) fix(gatsby-plugin-gatsby-cloud): fix cloud being bundled (gatsbyjs#31604) chore(gatsby-source-wordpress): Fix typos (gatsbyjs#31600) chore(docs): Add title to release notes (gatsbyjs#31595) ...
LekoArts
pushed a commit
that referenced
this pull request
Jun 2, 2021
(cherry picked from commit 2e1f7e3)
LekoArts
pushed a commit
that referenced
this pull request
Jun 2, 2021
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason the progress bar is messed up for me with the latest Contentful plugin (on Windows/cmder):
before-s.mp4
So what's happening is that we don't update the total count and so current progress is always greater than the total count which messes CLI rendering of the progress.
With this PR it seems to be working correctly:
after-s.mp4
Code from this PR was originally in the plugin. But it was removed in #30257. Not sure if it was intentional or not @axe312ger ? If not, then we should restore it back I guess.