feat(gatsby): Speedup building Functions by disabling minification #31473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up building Functions in the functions integration test from 2.3s to 0.65s. Minification is much more useful for preparing JS for browsers vs. serverless functions as many browsers are running on slow devices on slow networks so we want to make JS bundles as small as possible. Serverless functions, on the other hand, are loaded by servers over very fast networks so the extra CPU/memory costs to minify isn't worth it.
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: functions
and removed
status: triage needed
wardpeet
approved these changes
May 19, 2021
LekoArts
added
the
topic: DX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up building Functions in the functions integration test from 2.3s to 0.65s.
Minification is much more useful for preparing JS for browsers vs. serverless functions as many browsers are running on slow devices on slow networks so we want to make JS bundles as small as possible.
Serverless functions, on the other hand, are loaded by servers over very fast networks so the extra CPU/memory costs to minify isn't worth it.