Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-wordpress): auto-alias any field named fields to prevent conflicts with Gatsby core #31526

Merged
merged 3 commits into from May 21, 2021
Merged

feat(gatsby-source-wordpress): auto-alias any field named fields to prevent conflicts with Gatsby core #31526

merged 3 commits into from May 21, 2021

Conversation

Marco-Daniel
Copy link
Contributor

Description

@TylerBarnes PR to add an alias for the field 'fields' when sourcing form from Wordpress using wp-graphql-ninja-forms as discussed in the slack channel.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 21, 2021
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It looks great 👍 Looks like the failing tests are unrelated but I just triggered them again to see if they'll work this time.

@TylerBarnes TylerBarnes changed the title Update remoteSchema.ts feat(gatsby-source-wordpress): auto-alias any field named fields to prevent conflicts with Gatsby core May 21, 2021
@TylerBarnes
Copy link
Contributor

All the failing tests are unrelated and the WP tests pass so I'm gonna merge. A canary is published in gatsby-source-wordpress@5.7.0-alpha-wordpress.1+6df215e601 for anyone who needs this before the next Gatsby monorepo release (which should be on May 3rd I believe).

@TylerBarnes TylerBarnes merged commit 8bdb7f5 into gatsbyjs:master May 21, 2021
@Marco-Daniel Marco-Daniel deleted the fix/gatsby-source-wordpress-ninja-forms-field branch May 25, 2021 08:28
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants