Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contentful): reenable support for gif images #31986

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

axe312ger
Copy link
Collaborator

With the rewrite to gatsby-plugin-image and Gatsby v3 we are more strict when calling the Contentful Images API

Unfortunately, as we now always pass a image format. This broke gif support:

Before we called like this: https://images.ctfassets.net/k8iqpp6u0ior/2uMYE0Za3MOF9eVrx7eyiW/ace850f7bf6cbf52e3922b5db8379b7a/gatsby-monogram-animated.gif?w=150

Now we call like this: https://images.ctfassets.net/k8iqpp6u0ior/2uMYE0Za3MOF9eVrx7eyiW/ace850f7bf6cbf52e3922b5db8379b7a/gatsby-monogram-animated.gif?w=150&fm=gif

Which unfortunately fails:

{
  "sys": {
    "type": "Error",
    "id": "ParameterValuesNotAllowed",
    "details": {
      "error": "required fm: 'gif' valid transformation: False"
    }
  }
}

Good news: This is a configuration bug in the Contentful API and will be fixed very very soon.

This patch allows gifs now as image format as well :)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 18, 2021
@axe312ger axe312ger marked this pull request as draft June 18, 2021 14:18
@axe312ger
Copy link
Collaborator Author

Will remove the draft as soon the API fix is deployed.

@axe312ger axe312ger marked this pull request as ready for review June 18, 2021 14:56
@axe312ger
Copy link
Collaborator Author

The fix is rolled out :)

@axe312ger axe312ger added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 19, 2021
@wardpeet wardpeet added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: needs core review Currently awaiting review from Core team member labels Jun 22, 2021
@wardpeet wardpeet added this to To cherry-pick in Release candidate via automation Jun 22, 2021
@wardpeet wardpeet added this to To cherry-pick in V3 Release Hotfixes via automation Jun 22, 2021
@wardpeet wardpeet merged commit a30aa0b into master Jun 22, 2021
@wardpeet wardpeet deleted the fix/contentful-gif-support branch June 22, 2021 09:49
vladar pushed a commit that referenced this pull request Jun 22, 2021
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Jun 22, 2021
gatsbybot pushed a commit that referenced this pull request Jun 22, 2021
(cherry picked from commit a30aa0b)

Co-authored-by: Benedikt Rötsch <axe312ger@users.noreply.github.com>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Jun 22, 2021
@vladar vladar moved this from To cherry-pick to Won't merge in V3 Release Hotfixes Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants