feat(gatsby-source-drupal): Disable caching + add http/2 agent (#32012) #32038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(gatsby-source-drupal): Force revalidation on Drupal API requests Talking to Gatsby/Drupal users — most set long max-age for the Drupal cache to keep their edge http cache as fresh as possible as Drupal can directly purge its edge http cache. But this has the unfortunate side-effect with the recent http client change in #31514 that API calls aren't revalidated. Meaning that a user could change some content in Drupal and not see those updates in their Gatsby site until the Drupal cache expires in the Gatsby cache. This PR removes the `cache-control` header from Drupal API responses so that we only can use `etag` for caching which forces revalidation on every request. * Remove debugging line * Add http/2 agent * Disable cache — it's slower than refetch with revalidation * push don't concat * consistent return * Fix statusCode check for got * Actually this was correct... * Actually use http/2 (cherry picked from commit 113e43e) # Conflicts: # packages/gatsby-source-drupal/package.json
gatsbot
bot
added
the
status: triage needed
vladar
added
type: cherry
and removed
status: triage needed
This was referenced Jun 23, 2021
This was referenced Jan 18, 2022
This was referenced Oct 28, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #32012 to the 3.8 release branch.
(cherry picked from commit 113e43e)