fix(gatsby-source-wordpress): Move the remote url !== options url check earlier in previews #32251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
This was referenced Jul 5, 2021
Merged
DanielSLew
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check helps users who have misconfigured their Gatsby site and are trying to preview from a different WP instance than the one the Gatsby site is sourcing data from.
This check always existed but stopped working after a large preview scalability refactor. The check was running too late (after we made the request with incorrect credentials to pull pending previews) so it was never being hit. I moved it to be the first check in preview logic so it works again.
related: gatsbyjs/wp-gatsby#176