Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): let serve use getServerData headers #33159

Merged
merged 2 commits into from Sep 13, 2021
Merged

feat(gatsby): let serve use getServerData headers #33159

merged 2 commits into from Sep 13, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 13, 2021

Description

This exposes custom headers set by getServerData to engine integration and actually allows setting those reponse headers in gatsby serve

[ch37799]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 13, 2021
@pieh pieh added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 13, 2021
@pieh pieh marked this pull request as ready for review September 13, 2021 15:17
wardpeet
wardpeet reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about types

packages/gatsby/src/utils/page-ssr-module/entry.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/get-server-data.ts Outdated Show resolved Hide resolved
wardpeet
wardpeet approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wardpeet wardpeet merged commit fe2f09b into master Sep 13, 2021
@wardpeet wardpeet deleted the ssr-expose-headers branch September 13, 2021 18:19
This was referenced Jun 19, 2022
Open
Open
Open
This was referenced Jun 19, 2022
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jun 19, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 19, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 19, 2022
Open
@Rutam21 Rutam21 mentioned this pull request Jun 19, 2022
Open
This was referenced Jun 19, 2022
Open
Open
@saurabharch saurabharch mentioned this pull request Jun 19, 2022
Open
This was referenced Jun 19, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Jun 19, 2022
Open
This was referenced Jun 19, 2022
Open
Open
Open
This was referenced Jan 31, 2023
Open
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Feb 1, 2023
Open
@0xSebin 0xSebin mentioned this pull request Feb 1, 2023
Open
This was referenced Feb 1, 2023
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Mar 24, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pieh @wardpeet