fix(gatsby): restore onPreBuild to being called right after bootstrap finishes #33591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… finishes Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
type: bug
|
The reason why I moved it lower was because it originally happened after query running so I moved it down as well. I'm not really opiniated about it so i'm fine with changing it, just giving context |
vladar
approved these changes
Oct 19, 2021
|
I was looking at git blame and it seemed to have been moved during the services refactor. Looking back earlier it was placed right after bootstrap then too. |
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
… finishes (gatsbyjs#33591) * fix(gatsby): restore onPreBuild to being called right after bootstrap finishes Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild * chore: format Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
… finishes (#33591) * fix(gatsby): restore onPreBuild to being called right after bootstrap finishes Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild * chore: format Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
This was referenced Jan 25, 2022
This was referenced Feb 19, 2022
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild